fix: wrap hue in HSLColor + add from_degrees#703
Open
zxq82lm wants to merge 4 commits intoplotters-rs:masterfrom
Open
fix: wrap hue in HSLColor + add from_degrees#703zxq82lm wants to merge 4 commits intoplotters-rs:masterfrom
zxq82lm wants to merge 4 commits intoplotters-rs:masterfrom
Conversation
nielsle
reviewed
Dec 7, 2025
nielsle
left a comment
There was a problem hiding this comment.
Drive by code review
I am not a maintainer.
|
Looks ready to me, this now has TWO reviews @AaronErhardt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch fixes the behavior of
HSLColorin Plotters when the hue value is outside the[0,1]range.Fix
[0,1)instead of clamped.The fix was tested with the following example code, originally reported in this issue #696:
Closes #696